75 lines
3.1 KiB
Markdown
75 lines
3.1 KiB
Markdown
|
# 2026-03-28 Q-004 Coverage Remediation Pass 14
|
||
|
|
|
||
|
|
## Scope
|
||
|
|
|
||
|
|
- Continue strict `Q-004` closure work after Pass 13.
|
||
|
|
- Fully close the remaining auth recovery page hotspots in:
|
||
|
|
- `frontend/admin/src/pages/auth/ForgotPasswordPage/ForgotPasswordPage.tsx`
|
||
|
|
- `frontend/admin/src/pages/auth/ResetPasswordPage/ResetPasswordPage.tsx`
|
||
|
|
- Re-verify closure through targeted page tests plus full frontend validation.
|
||
|
|
|
||
|
|
## Changes
|
||
|
|
|
||
|
|
### Frontend
|
||
|
|
|
||
|
|
- Added page-level coverage in:
|
||
|
|
- `frontend/admin/src/pages/auth/ForgotPasswordPage/ForgotPasswordPage.test.tsx`
|
||
|
|
- `frontend/admin/src/pages/auth/ResetPasswordPage/ResetPasswordPage.test.tsx`
|
||
|
|
- Newly covered behavior includes:
|
||
|
|
- password-reset capability enabled and disabled states
|
||
|
|
- capability-load failure fallback on forgot-password
|
||
|
|
- forgot-password success and backend failure handling
|
||
|
|
- reset-token missing, invalid, and valid states
|
||
|
|
- reset-password success flow and backend failure handling
|
||
|
|
|
||
|
|
### Backend
|
||
|
|
|
||
|
|
- No backend code changes were required in this pass.
|
||
|
|
|
||
|
|
## Verified Commands
|
||
|
|
|
||
|
|
```powershell
|
||
|
|
cd D:\project\frontend\admin
|
||
|
|
npm.cmd run test:run -- src/pages/auth/ForgotPasswordPage/ForgotPasswordPage.test.tsx src/pages/auth/ResetPasswordPage/ResetPasswordPage.test.tsx
|
||
|
|
npm.cmd run lint
|
||
|
|
npm.cmd run build
|
||
|
|
npm.cmd run test:coverage
|
||
|
|
```
|
||
|
|
|
||
|
|
## Results
|
||
|
|
|
||
|
|
### Frontend coverage
|
||
|
|
|
||
|
|
- Overall:
|
||
|
|
- statements `89.06%`
|
||
|
|
- branches `77.14%`
|
||
|
|
- functions `83.56%`
|
||
|
|
- lines `89.96%`
|
||
|
|
- Target areas:
|
||
|
|
- `src/pages/auth/ForgotPasswordPage/ForgotPasswordPage.tsx`: statements `100%`, branches `75%`, functions `100%`, lines `100%`
|
||
|
|
- `src/pages/auth/ResetPasswordPage/ResetPasswordPage.tsx`: statements `95%`, branches `94.44%`, functions `100%`, lines `95%`
|
||
|
|
- `src/pages/admin/ProfileSecurityPage/ProfileSecurityPage.tsx`: statements `90.35%`, branches `75.51%`, functions `92.45%`, lines `90.13%`
|
||
|
|
|
||
|
|
## Validation Notes
|
||
|
|
|
||
|
|
- Frontend full coverage now completes with `44` passing test files and `209` passing tests.
|
||
|
|
- The required sequential frontend validation path passed:
|
||
|
|
- `test:run -- src/pages/auth/ForgotPasswordPage/ForgotPasswordPage.test.tsx src/pages/auth/ResetPasswordPage/ResetPasswordPage.test.tsx`
|
||
|
|
- `lint`
|
||
|
|
- `build`
|
||
|
|
- `test:coverage`
|
||
|
|
- The successful frontend coverage run still emits one post-summary jsdom `AggregateError` network-noise line.
|
||
|
|
- It does not fail the command.
|
||
|
|
- It remains a real validation-hygiene issue and should continue to be tracked honestly.
|
||
|
|
|
||
|
|
## Real Conclusion
|
||
|
|
|
||
|
|
- `src/pages/auth/ForgotPasswordPage/ForgotPasswordPage.tsx` is no longer an open `Q-004` gap.
|
||
|
|
- `src/pages/auth/ResetPasswordPage/ResetPasswordPage.tsx` is no longer an open `Q-004` gap.
|
||
|
|
- `Q-004` still cannot be honestly declared closed.
|
||
|
|
- After this pass, the remaining higher-value frontend gaps shift more toward:
|
||
|
|
- app shell and routing surfaces such as `src/app/App.tsx`, `src/app/RootLayout.tsx`, and `src/app/router.tsx`
|
||
|
|
- still-uncovered safety fallback UI such as `src/components/common/ErrorBoundary/ErrorBoundary.tsx`
|
||
|
|
- still-uncovered admin shell/page entry points such as `src/pages/admin/DashboardPage/DashboardPage.tsx`
|
||
|
|
- the post-summary jsdom `AggregateError` coverage-noise hygiene issue
|