fix logger and redeem admin review findings

backend/internal/handler/admin/admin_basic_handlers_test.go

@@ -7,6 +7,7 @@ import (
 	"net/http/httptest"
 	"testing"
 
+	"github.com/Wei-Shaw/sub2api/internal/service"
 	"github.com/gin-gonic/gin"
 	"github.com/stretchr/testify/require"
 )
@@ -226,7 +227,13 @@ func TestProxyHandlerEndpoints(t *testing.T) {
 }
 
 func TestRedeemHandlerEndpoints(t *testing.T) {
-	router, _ := setupAdminRouter()
+	router, adminSvc := setupAdminRouter()
+	adminSvc.batchDeleteRedeemResult = &service.RedeemBatchDeleteResult{
+		DeletedIDs: []int64{1},
+		Skipped: []service.RedeemBatchDeleteSkipped{
+			{ID: 2, Reason: "db error"},
+		},
+	}
 
 	rec := httptest.NewRecorder()
 	req := httptest.NewRequest(http.MethodGet, "/api/v1/admin/redeem-codes", nil)
@@ -255,6 +262,20 @@ func TestRedeemHandlerEndpoints(t *testing.T) {
 	req.Header.Set("Content-Type", "application/json")
 	router.ServeHTTP(rec, req)
 	require.Equal(t, http.StatusOK, rec.Code)
+	var resp struct {
+		Code int `json:"code"`
+		Data struct {
+			DeletedIDs []int64 `json:"deleted_ids"`
+			Skipped    []struct {
+				ID     int64  `json:"id"`
+				Reason string `json:"reason"`
+			} `json:"skipped"`
+		} `json:"data"`
+	}
+	require.NoError(t, json.Unmarshal(rec.Body.Bytes(), &resp))
+	require.Equal(t, []int64{1}, resp.Data.DeletedIDs)
+	require.Len(t, resp.Data.Skipped, 1)
+	require.Equal(t, int64(2), resp.Data.Skipped[0].ID)
 
 	rec = httptest.NewRecorder()
 	req = httptest.NewRequest(http.MethodPost, "/api/v1/admin/redeem-codes/5/expire", nil)

backend/internal/handler/admin/admin_service_stub_test.go

@@ -58,7 +58,8 @@ type stubAdminService struct {
 		sortOrder string
 		calls     int
 	}
-	mu sync.Mutex
+	batchDeleteRedeemResult *service.RedeemBatchDeleteResult
+	mu                      sync.Mutex
 }
 
 func newStubAdminService() *stubAdminService {
@@ -449,8 +450,11 @@ func (s *stubAdminService) DeleteRedeemCode(ctx context.Context, id int64) error
 	return nil
 }
 
-func (s *stubAdminService) BatchDeleteRedeemCodes(ctx context.Context, ids []int64) (int64, error) {
-	return int64(len(ids)), nil
+func (s *stubAdminService) BatchDeleteRedeemCodes(ctx context.Context, ids []int64) (*service.RedeemBatchDeleteResult, error) {
+	if s.batchDeleteRedeemResult != nil {
+		return s.batchDeleteRedeemResult, nil
+	}
+	return &service.RedeemBatchDeleteResult{DeletedIDs: ids, Skipped: []service.RedeemBatchDeleteSkipped{}}, nil
 }
 
 func (s *stubAdminService) ExpireRedeemCode(ctx context.Context, id int64) (*service.RedeemCode, error) {

backend/internal/handler/admin/redeem_handler.go

@@ -249,16 +249,13 @@ func (h *RedeemHandler) BatchDelete(c *gin.Context) {
 		return
 	}
 
-	deleted, err := h.adminService.BatchDeleteRedeemCodes(c.Request.Context(), req.IDs)
+	result, err := h.adminService.BatchDeleteRedeemCodes(c.Request.Context(), req.IDs)
 	if err != nil {
 		response.ErrorFrom(c, err)
 		return
 	}
 
-	response.Success(c, gin.H{
-		"deleted": deleted,
-		"message": "Redeem codes deleted successfully",
-	})
+	response.Success(c, result)
 }
 
 // Expire handles expiring a redeem code