Commit Graph

3 Commits

Author SHA1 Message Date
User
146a306343 fix: resolve 3 test package failures for Windows compatibility
Some checks failed
CI / test (push) Has been cancelled
CI / golangci-lint (push) Has been cancelled
Security Scan / backend-security (push) Has been cancelled
Security Scan / frontend-security (push) Has been cancelled
- config: add optional configPaths parameter to load() for test isolation
  (tests now use t.TempDir() to avoid interference from D:\app\data)
- handler: fix stubAccountRepoForHandler.ListByPlatform to return accounts
  (was returning nil, nil causing "no available accounts" errors)
- logger: fix Sync() blocking on Windows pipes by closing write end first
  (also add Reset() function to close lumberjack file handles for cleanup)
2026-04-13 01:09:46 +08:00
Developer
d4a2397740 fix: resolve P0/P1 code quality issues
- Add context parameter to shouldClearStickySession in tests
- Return 501 NotImplemented for TestCredentials
- Remove unused user variable in redeem_service
- Add comment for context.Background goroutine in promo_service
- Uncomment sora_client_handler tests (17 skipped tests)
- Add math/rand usage comment in request_transformer
- Fix ModelError.Error() to use fmt.Sprintf
- Add NotImplemented error type to errors package
- Optimize SSE defaultMaxLineSize from 500MB to 10MB
2026-04-01 13:39:37 +08:00
Developer
da36506b89 fix: resolve P0/P1 code quality issues
P0 fixes:
- ModelError.Is(): use exact matching instead of substring contains()
- shouldClearStickySession: add context param for cancellation/tracing

P1 fixes:
- TODO stubs: return 501 Not Implemented errors
- validateInstanceSignature: deduplicate to shared validateCodeSignature()
- Error messages: standardize to English only
- http.go: remove pseudo if-else with duplicate branches
2026-03-31 11:39:18 +08:00