- Fix MaskMap to properly handle []string sensitive fields - Add missing slice handling in sanitizer - Add comprehensive tests for GetMetrics and CreateEventsBatch - Improve audit/handler coverage from 49.8% to 68.8% - Fix test expectations to match actual sanitizer behavior - All tests pass
555 lines
16 KiB
Go
555 lines
16 KiB
Go
package handler
|
||
|
||
import (
|
||
"bytes"
|
||
"context"
|
||
"encoding/json"
|
||
"net/http"
|
||
"net/http/httptest"
|
||
"testing"
|
||
|
||
"lijiaoqiao/supply-api/internal/audit/model"
|
||
"lijiaoqiao/supply-api/internal/audit/service"
|
||
|
||
"github.com/stretchr/testify/assert"
|
||
)
|
||
|
||
// mockAuditStore 模拟审计存储
|
||
type mockAuditStore struct {
|
||
events []*model.AuditEvent
|
||
nextID int64
|
||
idempotencyKeys map[string]*model.AuditEvent
|
||
}
|
||
|
||
func newMockAuditStore() *mockAuditStore {
|
||
return &mockAuditStore{
|
||
events: make([]*model.AuditEvent, 0),
|
||
nextID: 1,
|
||
idempotencyKeys: make(map[string]*model.AuditEvent),
|
||
}
|
||
}
|
||
|
||
func (m *mockAuditStore) Emit(ctx context.Context, event *model.AuditEvent) error {
|
||
if event.EventID == "" {
|
||
event.EventID = "test-event-id"
|
||
}
|
||
m.events = append(m.events, event)
|
||
if event.IdempotencyKey != "" {
|
||
m.idempotencyKeys[event.IdempotencyKey] = event
|
||
}
|
||
return nil
|
||
}
|
||
|
||
func (m *mockAuditStore) EmitBatch(ctx context.Context, events []*model.AuditEvent) error {
|
||
for _, event := range events {
|
||
if err := m.Emit(ctx, event); err != nil {
|
||
return err
|
||
}
|
||
}
|
||
return nil
|
||
}
|
||
|
||
func (m *mockAuditStore) Query(ctx context.Context, filter *service.EventFilter) ([]*model.AuditEvent, int64, error) {
|
||
var result []*model.AuditEvent
|
||
for _, e := range m.events {
|
||
if filter.TenantID != 0 && e.TenantID != filter.TenantID {
|
||
continue
|
||
}
|
||
if filter.Category != "" && e.EventCategory != filter.Category {
|
||
continue
|
||
}
|
||
result = append(result, e)
|
||
}
|
||
return result, int64(len(result)), nil
|
||
}
|
||
|
||
func (m *mockAuditStore) GetByIdempotencyKey(ctx context.Context, key string) (*model.AuditEvent, error) {
|
||
if e, ok := m.idempotencyKeys[key]; ok {
|
||
return e, nil
|
||
}
|
||
return nil, nil
|
||
}
|
||
|
||
func (m *mockAuditStore) GetByEventID(ctx context.Context, eventID string) (*model.AuditEvent, error) {
|
||
for _, e := range m.events {
|
||
if e.EventID == eventID {
|
||
return e, nil
|
||
}
|
||
}
|
||
return nil, service.ErrEventNotFound
|
||
}
|
||
|
||
// TestAuditHandler_CreateEvent_Success 测试创建事件成功
|
||
func TestAuditHandler_CreateEvent_Success(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
reqBody := CreateEventRequest{
|
||
EventName: "CRED-EXPOSE-RESPONSE",
|
||
EventCategory: "CRED",
|
||
EventSubCategory: "EXPOSE",
|
||
OperatorID: 1001,
|
||
TenantID: 2001,
|
||
ObjectType: "account",
|
||
ObjectID: 12345,
|
||
Action: "query",
|
||
}
|
||
|
||
body, _ := json.Marshal(reqBody)
|
||
req := httptest.NewRequest("POST", "/audit/events", bytes.NewReader(body))
|
||
req.Header.Set("Content-Type", "application/json")
|
||
w := httptest.NewRecorder()
|
||
|
||
h.CreateEvent(w, req)
|
||
|
||
assert.Equal(t, http.StatusCreated, w.Code)
|
||
|
||
var result service.CreateEventResult
|
||
err := json.Unmarshal(w.Body.Bytes(), &result)
|
||
assert.NoError(t, err)
|
||
assert.Equal(t, 201, result.StatusCode)
|
||
assert.Equal(t, "created", result.Status)
|
||
}
|
||
|
||
// TestAuditHandler_CreateEvent_DuplicateIdempotencyKey 测试幂等键重复
|
||
func TestAuditHandler_CreateEvent_DuplicateIdempotencyKey(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
reqBody := CreateEventRequest{
|
||
EventName: "CRED-EXPOSE-RESPONSE",
|
||
EventCategory: "CRED",
|
||
EventSubCategory: "EXPOSE",
|
||
OperatorID: 1001,
|
||
TenantID: 2001,
|
||
IdempotencyKey: "test-idempotency-key",
|
||
}
|
||
|
||
body, _ := json.Marshal(reqBody)
|
||
|
||
// 第一次请求
|
||
req1 := httptest.NewRequest("POST", "/audit/events", bytes.NewReader(body))
|
||
req1.Header.Set("Content-Type", "application/json")
|
||
w1 := httptest.NewRecorder()
|
||
h.CreateEvent(w1, req1)
|
||
assert.Equal(t, http.StatusCreated, w1.Code)
|
||
|
||
// 第二次请求(相同幂等键)
|
||
req2 := httptest.NewRequest("POST", "/audit/events", bytes.NewReader(body))
|
||
req2.Header.Set("Content-Type", "application/json")
|
||
w2 := httptest.NewRecorder()
|
||
h.CreateEvent(w2, req2)
|
||
assert.Equal(t, http.StatusOK, w2.Code) // 应该返回200而非201
|
||
}
|
||
|
||
// TestAuditHandler_ListEvents_Success 测试查询事件成功
|
||
func TestAuditHandler_ListEvents_Success(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
// 先创建一些事件
|
||
events := []*model.AuditEvent{
|
||
{EventName: "EVENT-1", TenantID: 2001, EventCategory: "CRED"},
|
||
{EventName: "EVENT-2", TenantID: 2001, EventCategory: "CRED"},
|
||
{EventName: "EVENT-3", TenantID: 2002, EventCategory: "AUTH"},
|
||
}
|
||
for _, e := range events {
|
||
store.Emit(context.Background(), e)
|
||
}
|
||
|
||
// 查询
|
||
req := httptest.NewRequest("GET", "/audit/events?tenant_id=2001", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.ListEvents(w, req)
|
||
|
||
assert.Equal(t, http.StatusOK, w.Code)
|
||
|
||
var result ListEventsResponse
|
||
err := json.Unmarshal(w.Body.Bytes(), &result)
|
||
assert.NoError(t, err)
|
||
assert.Equal(t, int64(2), result.Total) // 只有2个2001租户的事件
|
||
}
|
||
|
||
// TestAuditHandler_ListEvents_WithPagination 测试分页查询
|
||
func TestAuditHandler_ListEvents_WithPagination(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
// 创建多个事件
|
||
for i := 0; i < 5; i++ {
|
||
store.Emit(context.Background(), &model.AuditEvent{
|
||
EventName: "EVENT",
|
||
TenantID: 2001,
|
||
})
|
||
}
|
||
|
||
req := httptest.NewRequest("GET", "/audit/events?tenant_id=2001&offset=0&limit=2", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.ListEvents(w, req)
|
||
|
||
assert.Equal(t, http.StatusOK, w.Code)
|
||
|
||
var result ListEventsResponse
|
||
json.Unmarshal(w.Body.Bytes(), &result)
|
||
assert.Equal(t, int64(5), result.Total)
|
||
assert.Equal(t, 0, result.Offset)
|
||
assert.Equal(t, 2, result.Limit)
|
||
}
|
||
|
||
// TestAuditHandler_InvalidRequest 测试无效请求
|
||
func TestAuditHandler_InvalidRequest(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
req := httptest.NewRequest("POST", "/audit/events", bytes.NewReader([]byte("invalid json")))
|
||
req.Header.Set("Content-Type", "application/json")
|
||
w := httptest.NewRecorder()
|
||
|
||
h.CreateEvent(w, req)
|
||
|
||
assert.Equal(t, http.StatusBadRequest, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_MissingRequiredFields 测试缺少必填字段
|
||
func TestAuditHandler_MissingRequiredFields(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
// 缺少EventName
|
||
reqBody := CreateEventRequest{
|
||
EventCategory: "CRED",
|
||
OperatorID: 1001,
|
||
}
|
||
|
||
body, _ := json.Marshal(reqBody)
|
||
req := httptest.NewRequest("POST", "/audit/events", bytes.NewReader(body))
|
||
req.Header.Set("Content-Type", "application/json")
|
||
w := httptest.NewRecorder()
|
||
|
||
h.CreateEvent(w, req)
|
||
|
||
assert.Equal(t, http.StatusBadRequest, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_GetEvent_Success 测试获取单个事件成功
|
||
func TestAuditHandler_GetEvent_Success(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
// 先创建一个事件
|
||
event := &model.AuditEvent{
|
||
EventID: "test-event-123",
|
||
EventName: "CRED-EXPOSE-RESPONSE",
|
||
TenantID: 2001,
|
||
EventCategory: "CRED",
|
||
}
|
||
store.Emit(context.Background(), event)
|
||
|
||
// 获取事件
|
||
req := httptest.NewRequest("GET", "/api/v1/audit/events/test-event-123", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.GetEvent(w, req)
|
||
|
||
assert.Equal(t, http.StatusOK, w.Code)
|
||
|
||
var result GetEventResponse
|
||
err := json.Unmarshal(w.Body.Bytes(), &result)
|
||
assert.NoError(t, err)
|
||
assert.Equal(t, "test-event-123", result.Event.EventID)
|
||
assert.Equal(t, "CRED-EXPOSE-RESPONSE", result.Event.EventName)
|
||
}
|
||
|
||
// TestAuditHandler_GetEvent_NotFound 测试事件不存在
|
||
func TestAuditHandler_GetEvent_NotFound(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
req := httptest.NewRequest("GET", "/api/v1/audit/events/nonexistent-id", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.GetEvent(w, req)
|
||
|
||
assert.Equal(t, http.StatusNotFound, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_GetEvent_MissingEventID 测试缺少事件ID
|
||
func TestAuditHandler_GetEvent_MissingEventID(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
req := httptest.NewRequest("GET", "/api/v1/audit/events/", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.GetEvent(w, req)
|
||
|
||
assert.Equal(t, http.StatusBadRequest, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_NewAuditHandlerWithMetrics 测试创建带指标的处理器
|
||
func TestAuditHandler_NewAuditHandlerWithMetrics(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
metricsSvc := service.NewMetricsService(svc)
|
||
h := NewAuditHandlerWithMetrics(svc, metricsSvc)
|
||
|
||
assert.NotNil(t, h)
|
||
assert.NotNil(t, h.svc)
|
||
assert.NotNil(t, h.metricsSvc)
|
||
}
|
||
|
||
// TestAuditHandler_GetMetrics_Success 测试获取指标成功
|
||
func TestAuditHandler_GetMetrics_Success(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
metricsSvc := service.NewMetricsService(svc)
|
||
h := NewAuditHandlerWithMetrics(svc, metricsSvc)
|
||
|
||
req := httptest.NewRequest("GET", "/audit/metrics?metric_id=m013", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.GetMetrics(w, req)
|
||
|
||
assert.Equal(t, http.StatusOK, w.Code)
|
||
|
||
var result service.Metric
|
||
err := json.Unmarshal(w.Body.Bytes(), &result)
|
||
assert.NoError(t, err)
|
||
assert.Equal(t, "M-013", result.MetricID)
|
||
}
|
||
|
||
// TestAuditHandler_GetMetrics_M014 测试获取M014指标
|
||
func TestAuditHandler_GetMetrics_M014(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
metricsSvc := service.NewMetricsService(svc)
|
||
h := NewAuditHandlerWithMetrics(svc, metricsSvc)
|
||
|
||
req := httptest.NewRequest("GET", "/audit/metrics?metric_id=m014", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.GetMetrics(w, req)
|
||
|
||
assert.Equal(t, http.StatusOK, w.Code)
|
||
|
||
var result service.Metric
|
||
json.Unmarshal(w.Body.Bytes(), &result)
|
||
assert.Equal(t, "M-014", result.MetricID)
|
||
}
|
||
|
||
// TestAuditHandler_GetMetrics_M015 测试获取M015指标
|
||
func TestAuditHandler_GetMetrics_M015(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
metricsSvc := service.NewMetricsService(svc)
|
||
h := NewAuditHandlerWithMetrics(svc, metricsSvc)
|
||
|
||
req := httptest.NewRequest("GET", "/audit/metrics?metric_id=m015", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.GetMetrics(w, req)
|
||
|
||
assert.Equal(t, http.StatusOK, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_GetMetrics_M016 测试获取M016指标
|
||
func TestAuditHandler_GetMetrics_M016(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
metricsSvc := service.NewMetricsService(svc)
|
||
h := NewAuditHandlerWithMetrics(svc, metricsSvc)
|
||
|
||
req := httptest.NewRequest("GET", "/audit/metrics?metric_id=m016", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.GetMetrics(w, req)
|
||
|
||
assert.Equal(t, http.StatusOK, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_GetMetrics_InvalidMetric 测试无效指标ID
|
||
func TestAuditHandler_GetMetrics_InvalidMetric(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
metricsSvc := service.NewMetricsService(svc)
|
||
h := NewAuditHandlerWithMetrics(svc, metricsSvc)
|
||
|
||
req := httptest.NewRequest("GET", "/audit/metrics?metric_id=invalid", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.GetMetrics(w, req)
|
||
|
||
assert.Equal(t, http.StatusBadRequest, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_GetMetrics_NoMetricsService 测试指标服务不可用
|
||
func TestAuditHandler_GetMetrics_NoMetricsService(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc) // 没有 metricsSvc
|
||
|
||
req := httptest.NewRequest("GET", "/audit/metrics?metric_id=m013", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.GetMetrics(w, req)
|
||
|
||
assert.Equal(t, http.StatusServiceUnavailable, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_CreateEventsBatch_Success 测试批量创建事件成功
|
||
func TestAuditHandler_CreateEventsBatch_Success(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
reqBody := CreateEventsBatchRequest{
|
||
Events: []*CreateEventRequest{
|
||
{
|
||
EventName: "EVENT-1",
|
||
EventCategory: "CRED",
|
||
OperatorID: 1001,
|
||
TenantID: 2001,
|
||
},
|
||
{
|
||
EventName: "EVENT-2",
|
||
EventCategory: "AUTH",
|
||
OperatorID: 1002,
|
||
TenantID: 2001,
|
||
},
|
||
},
|
||
}
|
||
|
||
body, _ := json.Marshal(reqBody)
|
||
req := httptest.NewRequest("POST", "/audit/events/batch", bytes.NewReader(body))
|
||
req.Header.Set("Content-Type", "application/json")
|
||
w := httptest.NewRecorder()
|
||
|
||
h.CreateEventsBatch(w, req)
|
||
|
||
assert.Equal(t, http.StatusOK, w.Code)
|
||
|
||
var result CreateEventsBatchResponse
|
||
json.Unmarshal(w.Body.Bytes(), &result)
|
||
assert.Equal(t, 2, result.SuccessCount)
|
||
assert.Equal(t, 0, result.FailCount)
|
||
}
|
||
|
||
// TestAuditHandler_CreateEventsBatch_Empty 测试空批次
|
||
func TestAuditHandler_CreateEventsBatch_Empty(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
reqBody := CreateEventsBatchRequest{
|
||
Events: []*CreateEventRequest{},
|
||
}
|
||
|
||
body, _ := json.Marshal(reqBody)
|
||
req := httptest.NewRequest("POST", "/audit/events/batch", bytes.NewReader(body))
|
||
req.Header.Set("Content-Type", "application/json")
|
||
w := httptest.NewRecorder()
|
||
|
||
h.CreateEventsBatch(w, req)
|
||
|
||
assert.Equal(t, http.StatusBadRequest, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_CreateEventsBatch_TooLarge 测试批次太大
|
||
func TestAuditHandler_CreateEventsBatch_TooLarge(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
// 创建51个事件(超过50的限制)
|
||
events := make([]*CreateEventRequest, 51)
|
||
for i := range events {
|
||
events[i] = &CreateEventRequest{
|
||
EventName: "EVENT",
|
||
EventCategory: "CRED",
|
||
}
|
||
}
|
||
|
||
reqBody := CreateEventsBatchRequest{Events: events}
|
||
body, _ := json.Marshal(reqBody)
|
||
req := httptest.NewRequest("POST", "/audit/events/batch", bytes.NewReader(body))
|
||
req.Header.Set("Content-Type", "application/json")
|
||
w := httptest.NewRecorder()
|
||
|
||
h.CreateEventsBatch(w, req)
|
||
|
||
assert.Equal(t, http.StatusBadRequest, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_CreateEventsBatch_MissingEventName 测试缺少事件名
|
||
func TestAuditHandler_CreateEventsBatch_MissingEventName(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
reqBody := CreateEventsBatchRequest{
|
||
Events: []*CreateEventRequest{
|
||
{
|
||
EventCategory: "CRED", // 缺少 EventName
|
||
},
|
||
},
|
||
}
|
||
|
||
body, _ := json.Marshal(reqBody)
|
||
req := httptest.NewRequest("POST", "/audit/events/batch", bytes.NewReader(body))
|
||
req.Header.Set("Content-Type", "application/json")
|
||
w := httptest.NewRecorder()
|
||
|
||
h.CreateEventsBatch(w, req)
|
||
|
||
assert.Equal(t, http.StatusBadRequest, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_CreateEventsBatch_InvalidJSON 测试无效JSON
|
||
func TestAuditHandler_CreateEventsBatch_InvalidJSON(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
req := httptest.NewRequest("POST", "/audit/events/batch", bytes.NewReader([]byte("invalid json")))
|
||
req.Header.Set("Content-Type", "application/json")
|
||
w := httptest.NewRecorder()
|
||
|
||
h.CreateEventsBatch(w, req)
|
||
|
||
assert.Equal(t, http.StatusBadRequest, w.Code)
|
||
}
|
||
|
||
// TestAuditHandler_ListEvents_WithEventName 测试按事件名查询
|
||
func TestAuditHandler_ListEvents_WithEventName(t *testing.T) {
|
||
store := newMockAuditStore()
|
||
svc := service.NewAuditService(store)
|
||
h := NewAuditHandler(svc)
|
||
|
||
// 创建事件
|
||
events := []*model.AuditEvent{
|
||
{EventName: "EVENT-SPECIAL", TenantID: 2001, EventCategory: "CRED"},
|
||
{EventName: "EVENT-OTHER", TenantID: 2001, EventCategory: "AUTH"},
|
||
}
|
||
for _, e := range events {
|
||
store.Emit(context.Background(), e)
|
||
}
|
||
|
||
req := httptest.NewRequest("GET", "/audit/events?tenant_id=2001&event_name=EVENT-SPECIAL", nil)
|
||
w := httptest.NewRecorder()
|
||
|
||
h.ListEvents(w, req)
|
||
|
||
assert.Equal(t, http.StatusOK, w.Code)
|
||
}
|