Commit Graph

12 Commits

Author SHA1 Message Date
Developer
4d71566c0d fix: resolve all P0/P1 code quality issues
Some checks failed
CI / test (push) Has been cancelled
CI / golangci-lint (push) Has been cancelled
Security Scan / backend-security (push) Has been cancelled
Security Scan / frontend-security (push) Has been cancelled
P0 fixes:
- P0-01: sticky_session_test.go add context import
- P0-02: wire_gen.go add usageLogRepository parameter
- P0-03: admin_service_stub_test.go add GetGroupAPIKeyCount
- P0-04: admin_basic_handlers_test.go add stubUsageLogRepository

P1 fixes:
- P1-03: group_handler.go GetStats implement real data query

E2E fixes:
- Fix API Key path to /api/v1/keys (user endpoint)

Documentation:
- Update MEMORY.md with latest fixes
2026-04-03 12:54:16 +08:00
Developer
4bf838105b docs: update PROJECT_EXPERIENCE with comprehensive project lessons
- Add API routing structure (user /keys vs admin /api-keys)
- Add本次审查问题修复清单
- Add testing commands and coverage info
- Update common pitfalls section
2026-04-03 07:25:50 +08:00
Developer
daae3497af fix: add getModelStats mock to UsageView.spec.ts
- Add missing getModelStats mock to fix "adminAPI.dashboard.getModelStats is not a function" warning
2026-04-03 00:07:50 +08:00
Developer
413db94aeb fix: align api_key_handler.go comments with actual routes
- Routes are /api/v1/keys (not /api/v1/api-keys)
- Update CLAUDE.md and DEV_GUIDE.md with correct API paths
2026-04-03 00:00:23 +08:00
Developer
dc92194b2b docs: update project documentation with experience lessons
- DEV_GUIDE.md: Add E2E test pitfalls (坑12-15) and Gitea repo info
- CLAUDE.md: Add project experience summary and Gitea remote
- MEMORY.md: Update with all fixed issues (P0/P1/E2E)
- docs/PROJECT_EXPERIENCE.md: New comprehensive experience doc
2026-04-02 23:24:10 +08:00
Developer
8b19f56ba4 fix: update E2E test API paths and payloads to match backend
- user-apikey-lifecycle: /api/v1/keys -> /api/v1/api-keys (24 occurrences)
- admin-users: balance payload uses balance+operation+notes
- admin-groups: rate-multiplier already uses correct format
2026-04-02 22:35:48 +08:00
Developer
c660553c87 security: replace hardcoded OAuth credentials with placeholders
Some checks failed
CI / test (push) Has been cancelled
CI / golangci-lint (push) Has been cancelled
Security Scan / backend-security (push) Has been cancelled
Security Scan / frontend-security (push) Has been cancelled
- Replace Google OAuth ClientID/Secret with placeholder values
- Update test assertions to match new placeholder values
2026-04-02 14:19:10 +08:00
Developer
c303817800 test: fix AccountStatusIndicator and AccountUsageCell tests
Some checks failed
CI / test (push) Has been cancelled
CI / golangci-lint (push) Has been cancelled
Security Scan / backend-security (push) Has been cancelled
Security Scan / frontend-security (push) Has been cancelled
- AccountStatusIndicator: fix i18n key assertion (account.x → admin.accounts.status.x)
- AccountUsageCell: fix getUsage mock assertion to include undefined source param
2026-04-01 14:41:10 +08:00
Developer
6b060dd14d merge: resolve conflicts with remote, keep local fixes 2026-04-01 14:11:47 +08:00
Developer
d4a2397740 fix: resolve P0/P1 code quality issues
- Add context parameter to shouldClearStickySession in tests
- Return 501 NotImplemented for TestCredentials
- Remove unused user variable in redeem_service
- Add comment for context.Background goroutine in promo_service
- Uncomment sora_client_handler tests (17 skipped tests)
- Add math/rand usage comment in request_transformer
- Fix ModelError.Error() to use fmt.Sprintf
- Add NotImplemented error type to errors package
- Optimize SSE defaultMaxLineSize from 500MB to 10MB
2026-04-01 13:39:37 +08:00
phamnazage-jpg
a097055deb fix: resolve P0/P1 code quality issues
P0 fixes:
- ModelError.Is(): use exact matching instead of substring contains()
- shouldClearStickySession: add context param for cancellation/tracing

P1 fixes:
- TODO stubs: return 501 Not Implemented errors
- validateInstanceSignature: deduplicate to shared validateCodeSignature()
- Error messages: standardize to English only
- http.go: remove pseudo if-else with duplicate branches
2026-03-31 11:44:54 +08:00
Developer
da36506b89 fix: resolve P0/P1 code quality issues
P0 fixes:
- ModelError.Is(): use exact matching instead of substring contains()
- shouldClearStickySession: add context param for cancellation/tracing

P1 fixes:
- TODO stubs: return 501 Not Implemented errors
- validateInstanceSignature: deduplicate to shared validateCodeSignature()
- Error messages: standardize to English only
- http.go: remove pseudo if-else with duplicate branches
2026-03-31 11:39:18 +08:00